Skip to content

Bluetooth: Mesh: Increase MBEDTLS_HEAP_SIZE for NLC samples #21319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

Bluetooth: Mesh: Increase MBEDTLS_HEAP_SIZE for NLC samples #21319

merged 1 commit into from
Apr 3, 2025

Conversation

@m-alperen-sener
Copy link
Contributor

@m-alperen-sener m-alperen-sener commented Apr 2, 2025 •
edited
Loading

Increasing the default MBEDTLS_HEAP_SIZE to 1152 to accommodate all the keys used by NLC profile.

@m-alperen-sener m-alperen-sener requested a review from a team as a code owner April 2, 2025 12:55
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 2, 2025
PavelVPV
PavelVPV requested changes Apr 2, 2025
View reviewed changes
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 2, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 775f782a65e062ebeb14c4cdcc2e7169977261f2

more details

sdk-nrf:

PR head: 775f782a65e062ebeb14c4cdcc2e7169977261f2
merge base: f3a5cfa880cdf976ac9806ffd88271b51b4e4853
target head (main): cbfbbe56f0feff3c51a60e71e8bfd1353a43b0cb
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1) 
subsys
│  ├── bluetooth
│  │  ├── mesh
│  │  │  │ Kconfig

Outputs:

Toolchain

Version: 7dbe0e2658
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:7dbe0e2658_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 900
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-ble_mesh
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@m-alperen-sener m-alperen-sener force-pushed the mesh_increase_psa_mbedtls_heap branch from 1d856b2 to 5b072a7 Compare April 2, 2025 14:12
@m-alperen-sener m-alperen-sener requested a review from a team as a code owner April 2, 2025 14:12
@github-actions github-actions bot added the ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. label Apr 2, 2025
@m-alperen-sener m-alperen-sener changed the title Samples: Bluetooth: Mesh: Increase MBEDTLS_HEAP_SIZE for NLC samples Bluetooth: Mesh: Increase MBEDTLS_HEAP_SIZE for NLC samples Apr 2, 2025
@m-alperen-sener
Copy link
Contributor Author

m-alperen-sener commented Apr 2, 2025

Sorry for the sudden dramatic scope change;

Moving changes to mesh kconfig, because MBEDTLS_HEAP_SIZE is only valid for MBEDTLS PSA. So mesh kconfig seems more appropriate for the change.

@m-alperen-sener
Bluetooth: Mesh: Increase default MBEDTLS_HEAP_SIZE for NLC profile
775f782 
Increasing the default MBEDTLS_HEAP_SIZE to 1152 to accommodate all
the keys used by NLC profile.

Signed-off-by: alperen sener <[email protected]>
@m-alperen-sener m-alperen-sener force-pushed the mesh_increase_psa_mbedtls_heap branch from 5b072a7 to 775f782 Compare April 2, 2025 14:17
@github-actions
Copy link

github-actions bot commented Apr 2, 2025

You can find the documentation preview for this PR here.

@PavelVPV
Copy link
Contributor

PavelVPV commented Apr 3, 2025

Release notes?

@m-alperen-sener m-alperen-sener marked this pull request as draft April 3, 2025 07:39
@m-alperen-sener m-alperen-sener marked this pull request as ready for review April 3, 2025 08:10
@m-alperen-sener
Copy link
Contributor Author

m-alperen-sener commented Apr 3, 2025 •
edited
Loading

Release notes?

I think we should make a collective release note for mesh PSA changes including all with this one.

@m-alperen-sener m-alperen-sener removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 3, 2025
@nordicjm nordicjm merged commit a529481 into nrfconnect:main Apr 3, 2025
15 checks passed
@m-alperen-sener
Copy link
Contributor Author

m-alperen-sener commented Apr 3, 2025

For release notes:
#21339 (comment)
#21339 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PavelVPV PavelVPV PavelVPV approved these changes

@nordicjm nordicjm nordicjm approved these changes

@akredalen akredalen akredalen approved these changes

Assignees

No one assigned

Labels

ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@m-alperen-sener @NordicBuilder @PavelVPV @nordicjm @akredalen